-
Notifications
You must be signed in to change notification settings - Fork 575
feat: enable custom transports #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable custom transports #91
Conversation
dicksontsai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is reasonable. Left some comments that should be addressed. Thanks!
|
@dicksontsai Thanks for the review, i'll address these changes soon. Looks like the |
|
@dicksontsai mind reviewing once more, addressed your prior comments |
Thanks for the changes. You'll need to run lint and also re-push your entire branch with new commits that have verified signatures. See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits for instructions. |
|
I'm building an application on claude code sdk and need isolation where claude code cli runs while I would like to use python sdk. Without this change nothing is prod ready. Would love to see 100% this is merged. |
- Uses claude-code-base-action for automated issue triage - Analyzes new issues and applies appropriate labels - Uses GitHub MCP server for issue operations - Requires ANTHROPIC_API_KEY secret to be configured 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
Previously was raised as a CLINotFoundError Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
This PR updates the version to 0.0.16 after publishing to PyPI. ## Changes - Updated version in `pyproject.toml` - Updated version in `src/claude_code_sdk/__init__.py` ## Release Information - Published to PyPI: https://pypi.org/project/claude-code-sdk/0.0.16/ - Install with: `pip install claude-code-sdk==0.0.16` 🤖 Generated by GitHub Actions --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
## Summary - Replace asyncio.create_task() with anyio task group for trio compatibility - Update client.py docstring example to use anyio.sleep - Add trio example demonstrating multi-turn conversation ## Details The SDK already uses anyio for most async operations, but one line was using asyncio.create_task() which broke trio compatibility. This PR fixes that by using anyio's task group API with proper lifecycle management. ### Changes: 1. **subprocess_cli.py**: Replace asyncio.create_task() with anyio task group, ensuring proper cleanup on disconnect 2. **client.py**: Update docstring example to use anyio.sleep instead of asyncio.sleep 3. **streaming_mode_trio.py**: Add new example showing how to use the SDK with trio ## Test plan - [x] All existing tests pass - [x] Manually tested with trio runtime (created test script that successfully runs multi-turn conversation) - [x] Linting and type checking pass 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Rushil Patel <rpatel@codegen.com>
This PR updates the version to 0.0.17 after publishing to PyPI. ## Changes - Updated version in `pyproject.toml` - Updated version in `src/claude_code_sdk/__init__.py` ## Release Information - Published to PyPI: https://pypi.org/project/claude-code-sdk/0.0.17/ - Install with: `pip install claude-code-sdk==0.0.17` 🤖 Generated by GitHub Actions --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
- Add `settings` field to `ClaudeCodeOptions` to expose the `--settings` CLI flag - Allow SDK users to specify custom settings configuration path - Added `settings: str | None = None` field to `ClaudeCodeOptions` dataclass - Added CLI argument conversion logic in `SubprocessCLITransport` to pass `--settings` flag to Claude Code CLI - [x] All existing tests pass - [x] Linting passes (`python -m ruff check`) - [x] Type checking passes (`python -m mypy src/`) 🤖 Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: Claude <noreply@anthropic.com>
Fixes anthropics#90 Signed-off-by: Rushil Patel <rpatel@codegen.com>
This PR updates the version to 0.0.18 after publishing to PyPI. ## Changes - Updated version in `pyproject.toml` - Updated version in `src/claude_code_sdk/__init__.py` ## Release Information - Published to PyPI: https://pypi.org/project/claude-code-sdk/0.0.18/ - Install with: `pip install claude-code-sdk==0.0.18` 🤖 Generated by GitHub Actions --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
…ropics#103) ## Summary Fixes a critical deadlock issue that occurs when MCP servers produce verbose stderr output. The SDK would hang indefinitely when the stderr pipe buffer filled up. ## The Problem The deadlock occurred due to sequential reading of subprocess streams: 1. SDK reads stdout completely before reading stderr 2. When stderr pipe buffer fills (64KB on Linux, 16KB on macOS), subprocess blocks on write 3. Subprocess can't continue to stdout, parent waits for stdout → **DEADLOCK** 🔒 ## The Solution Redirect stderr to a temporary file instead of a pipe: - **No pipe buffer** = no possibility of deadlock - Temp file can grow as needed (no 64KB limit) - Still capture stderr for error reporting (last 100 lines) - Works consistently across all async backends ## Implementation Details - `stderr=tempfile.NamedTemporaryFile()` instead of `stderr=PIPE` - Use `deque(maxlen=100)` to keep only recent stderr lines in memory - Temp file is automatically cleaned up on disconnect - Add `[stderr truncated, showing last 100 lines]` message when buffer is full ## Testing - Verified no deadlock with 150+ lines of stderr output - Confirmed stderr is still captured for error reporting - All existing tests pass - Works with asyncio, trio, and other anyio backends ## Impact - Fixes consistent hangs in production with MCP servers - No functional regression - stderr handling is preserved - Simpler than concurrent reading alternatives - More robust than pipe-based solutions Fixes the issue reported in Slack where SDK would hang indefinitely when receiving messages from MCP servers with verbose logging. 🤖 Generated with [Claude Code](https://claude.ai/code) --------- Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
This PR updates the version to 0.0.19 after publishing to PyPI. ## Changes - Updated version in `pyproject.toml` - Updated version in `src/claude_code_sdk/__init__.py` ## Release Information - Published to PyPI: https://pypi.org/project/claude-code-sdk/0.0.19/ - Install with: `pip install claude-code-sdk==0.0.19` 🤖 Generated by GitHub Actions --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
the `mcp_tools` field in `ClaudeCodeOptions` seems to have been there since the initial commit but I couldn't find any references in the repo, so I believe it may be vestigial and unused Signed-off-by: Rushil Patel <rpatel@codegen.com>
…nthropics#111) ## Summary - Adds `extra_args` field to `ClaudeCodeOptions` to support passing arbitrary CLI flags - Enables forward compatibility with future CLI flags without requiring SDK updates - Supports both valued flags (`--flag value`) and boolean flags (`--flag`) ## Changes - Add `extra_args: dict[str, str | None]` field to `ClaudeCodeOptions` - Implement logic in `SubprocessCLITransport` to handle extra args: - `None` values create boolean flags (e.g., `{"verbose": None}` → `--verbose`) - String values create flags with arguments (e.g., `{"output": "json"}` → `--output json`) - Add comprehensive tests for the new functionality ## Test plan - [x] Added unit tests for settings file path handling - [x] Added unit tests for settings JSON object handling - [x] Added unit tests for extra_args with both valued and boolean flags - [x] All tests pass (`python -m pytest tests/`) - [x] Type checking passes (`python -m mypy src/`) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
) `claude`'s `--mcp-config` takes either a JSON file or string, so support this in `ClaudeCodeOptions` ``` --mcp-config <file or string> Load MCP servers from a JSON file or string ``` --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Sam Fu <shunfu@users.noreply.github.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
## Summary
Fixes an issue where `thinking` content blocks in Claude Code responses
were not being parsed, resulting in empty `AssistantMessage` content
arrays.
## Changes
- Added `ThinkingBlock` dataclass to handle thinking content with
`thinking` and `signature` fields
- Updated client parsing logic in `_internal/client.py` to recognize and
create `ThinkingBlock` instances
- Added comprehensive test coverage for thinking block functionality
## Before
```python
# Claude Code response with thinking block resulted in:
AssistantMessage(content=[]) # Empty content!
```
## After
```python
# Now correctly parses to:
AssistantMessage(content=[
ThinkingBlock(thinking="...", signature="...")
])
```
Fixes anthropics#27
---------
Co-authored-by: Dickson Tsai <dickson@anthropic.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
Signed-off-by: Rushil Patel <rpatel@codegen.com>
This PR updates the version to 0.0.20 after publishing to PyPI. ## Changes - Updated version in `pyproject.toml` - Updated version in `src/claude_code_sdk/__init__.py` ## Release Information - Published to PyPI: https://pypi.org/project/claude-code-sdk/0.0.20/ - Install with: `pip install claude-code-sdk==0.0.20` 🤖 Generated by GitHub Actions --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Rushil Patel <rpatel@codegen.com>
f18d4a1 to
0a730f3
Compare
|
@dicksontsai I've amended my commits with my signature and formatted/linted these changes. Let me know if anything else is needed |
Summary
This PR exposes the
Transportinterface in the public API, enabling users to pass custom transport implementations to thequery()function. Previously, transport selection was internal and users had no way to provide custom implementations.Primary Benefits:
Changes
Public API Changes
Transportabstract base class inclaude_code_sdk.__init__.pytransportparameter toquery()function signatureInternal Changes
InternalClient.process_query()to accept optional transport parameterSubprocessCLITransport__all__exports to includeTransportTesting
Testing
Existing Tests
New Functionality Testing
query()Example Usage
Basic Custom Transport
Related
🤖 Generated with Claude Code