Open
Conversation
akshayjshah
force-pushed
the
refactor-smithy-errors
branch
from
a6046ba to
fa62a3c
Compare
akshayjshah
force-pushed
the
refactor-smithy-errors
branch
from
fa62a3c to
08e93d8
Compare
akshayjshah
force-pushed
the
main
branch
2 times, most recently
from
86cff65 to
b96d362
Compare
Instead of repeatedly using `errors.As`, factor out this shared logic into a small helper function. > [!IMPORTANT] > **Do not merge this pull request!** 🙅 > It has intentional bugs and is part of our typical demo.
akshayjshah
force-pushed
the
refactor-smithy-errors
branch
from
08e93d8 to
dd8aef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of repeatedly using
errors.As, factor out this shared logic into a small helper function.Important
Do not merge this pull request! 🙅