Skip to content

Revert "Fix: Country filter plain text (#452)" #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slavingia merged 1 commit into from
Jul 9, 2025
+0 −35
Merged

Revert "Fix: Country filter plain text (#452)" #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions e2e/settings/tax.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,40 +148,6 @@ test.describe("Tax settings", () => {
]);
});

test("allows searching for countries by name", async ({ page }) => {
await login(page, user);
await page.goto("/settings/tax");

// Test partial country name search
await page.getByRole("combobox", { name: "Country of citizenship" }).click();
await page.getByPlaceholder("Search...").fill("polan");
await expect(page.getByRole("option", { name: "Poland" })).toBeVisible();
await page.getByRole("option", { name: "Poland" }).click();
await expect(page.getByRole("combobox", { name: "Country of citizenship" })).toHaveText("Poland");

// Test another partial search
await page.getByRole("combobox", { name: "Country of residence" }).click();
await page.getByPlaceholder("Search...").fill("united sta");
await expect(page.getByRole("option", { name: "United States" })).toBeVisible();
await expect(page.getByRole("option", { name: "United States Minor Outlying Islands" })).toBeVisible();
await page.getByRole("option", { name: "United States" }).click();
await expect(page.getByRole("combobox", { name: "Country of residence" })).toHaveText("United States");

// Test case-insensitive search
await page.getByRole("combobox", { name: "Country of citizenship" }).click();
await page.getByPlaceholder("Search...").fill("CANADA");
await expect(page.getByRole("option", { name: "Canada" })).toBeVisible();
await page.getByRole("option", { name: "Canada" }).click();
await expect(page.getByRole("combobox", { name: "Country of citizenship" })).toHaveText("Canada");

// Test that country code still works
await page.getByRole("combobox", { name: "Country of residence" }).click();
await page.getByPlaceholder("Search...").fill("GB");
await expect(page.getByRole("option", { name: "United Kingdom" })).toBeVisible();
await page.getByRole("option", { name: "United Kingdom" }).click();
await expect(page.getByRole("combobox", { name: "Country of residence" })).toHaveText("United Kingdom");
});

test("allows confirming tax information", async ({ page }) => {
await userComplianceInfosFactory.create({ userId: user.id });
await login(page, user);
Expand Down
1 change: 0 additions & 1 deletion frontend/components/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ const ComboBox = ({
<CommandItem
key={option.value}
value={option.value}
keywords={[option.label]}
onSelect={(currentValue) => {
if (multiple) {
onChange(
Expand Down
Loading