Add clickable board links to Slack notifications#827
Closed
devin-ai-integration[bot] wants to merge 6 commits intomainfrom
Closed
Add clickable board links to Slack notifications#827devin-ai-integration[bot] wants to merge 6 commits intomainfrom
devin-ai-integration[bot] wants to merge 6 commits intomainfrom
Conversation
- Update formatNoteForSlack to include board URL in link format - Update formatTodoForSlack to include board URL in link format - Update updateSlackMessage to include board URL in link format - Update sendTodoNotification to pass board URL parameters - Add getBaseUrl import to API routes for URL construction - Use Slack's <URL|text> format for clickable board names Co-Authored-By: Sahil Lavingia <sahil@gumroad.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
update specs |
…ck messages Co-Authored-By: Sahil Lavingia <sahil@gumroad.com>
- Reduced from 3 tests to 1 comprehensive test - Fixed issue where empty notes don't trigger Slack notifications - Fixed issue where DB-created notes don't render in UI for E2E testing - Now creates note through UI and adds content via textarea - Follows pattern from existing notes.spec.ts for proper note creation - Unit tests comprehensively cover all three Slack formatting functions Co-Authored-By: Sahil Lavingia <sahil@gumroad.com>
The E2E test is not compatible with the app architecture: - Note creation Slack notifications require content at POST time - UI creates empty notes first (POST), then adds content via PUT - PUT with content doesn't trigger note creation notifications The comprehensive unit tests (18 tests in lib/__tests__/slack.test.ts) provide sufficient coverage for all Slack formatting functions and verify clickable board links work correctly. Co-Authored-By: Sahil Lavingia <sahil@gumroad.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add clickable board links to Slack notifications
Summary
Updates Slack notification messages to make board names clickable links instead of plain text. Previously messages showed "in {boardName}" but now use Slack's link format
<URL|board name>to link directly to the board.Changes:
lib/slack.tsto acceptboardIdandbaseUrlparameters<${baseUrl}/boards/${boardId}|${boardName}>formatgetBaseUrl(request)for URL constructionReview & Testing Checklist for Human
getBaseUrl(request)produces correct URLs in your deployment environment (both staging and production)Notes
<URL|display text>which should render as clickable linksgetBaseUrlutility function for consistent URL construction across environmentsRequested by: Sahil Lavingia (@slavingia)
Devin session: https://app.devin.ai/sessions/4ea42d60d173415ba79cc6540cb514da