Skip to content

Fix Elasticsearch BadRequest from non-Hash search param in profile pages #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gumclaw wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −0
Open

Fix Elasticsearch BadRequest from non-Hash search param in profile pages #4334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2f3952
Fix Elasticsearch BadRequest from non-Hash search param
gumclaw Apr 6, 2026
ef5306c
Move search param guard to format_search_params!
gumclaw Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/concerns/search_products.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ def format_search_params!
if params[:size].is_a?(String)
params[:size] = params[:size].to_i
end

params.delete(:search) unless params[:search].is_a?(Hash)
end

def offer_codes_search_feature_active?(params)
Expand Down
Loading