Fix LinkInvalid on disable for memberships with invalid tier structure#4342
Open
Fix LinkInvalid on disable for memberships with invalid tier structure#4342
Conversation
gumclaw
force-pushed
the
fix/link-invalid-on-disable
branch
from
f449f3b to
33f8f20
Compare
Skip tier version structure validation when a product is being unpublished, so users can disable products even if variant categories were deleted or became inconsistent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gumclaw
force-pushed
the
fix/link-invalid-on-disable
branch
from
33f8f20 to
05cb8c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Link::LinkInvalid: Memberships should only have one Tier version categoryis raised when trying to disable a membership product viaApi::V2::LinksController#disablevalid_tier_version_structurevalidation now skips whenpurchase_disabled_atis being set, allowing users to unpublish products even if the tier structure became inconsistent (e.g., variant categories were deleted)Test plan
LinkInvalidunpublish-related tests continue to pass🤖 Generated with Claude Code