Fix issue with index access on set in parserinterpreter.py#4760
Open
PatrickStahl wants to merge 2 commits intoantlr:devfrom
Open
Fix issue with index access on set in parserinterpreter.py#4760PatrickStahl wants to merge 2 commits intoantlr:devfrom
PatrickStahl wants to merge 2 commits intoantlr:devfrom
Conversation
Signed-off-by: Patrick Stahl <patrick.stahl@uni-jena.de>
Signed-off-by: Patrick Stahl <patrick.stahl@uni-jena.de>
ericvergnaud
requested changes
Feb 6, 2025
Contributor
ericvergnaud
left a comment
ericvergnaud
left a comment
There was a problem hiding this comment.
The fact that we have an incorrect indent in this PR cruelly highlights the lack of testing for this ParserInterpreter. Is that something you could create ?
|
|
||
| # Begin parsing at startRuleIndex# | ||
| def parse(self, startRuleIndex:int): | ||
| def parse(self, startRuleIndex:int): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the parserinterpreter.py file, there was an issue where an attempt was made to access a set using an index. However, sets do not support indexing, which led to an error.
This change fixes the issue by modifying the logic to access the elements of the set in a valid manner.