Open
Conversation
This aligns the golang runtime with other languages where the SetTokenSource is publicly available. We require this in our usage of antlr4. We currently have a fork for the sole purpose of this. Signed-off-by: Francois Saint-Jacques <francois.saintjacques@shopify.com>
fsaintjacques
force-pushed
the
go-set-token-source-public
branch
from
677da98 to
fafd42a
Compare
Author
Collaborator
|
I will. I am planning on doing a tree visitor overhaul very soon and at
that point I will incorporate any prs that make sense, or include trivial
ones in my own code. This one seems sensible, but right now I am working on
a few other things, so let’s leave this open and I will use it one way or
another
…On Wed, Apr 9, 2025 at 06:00 François Saint-Jacques < ***@***.***> wrote:
@parrt <https://github.com/parrt> & @jimidle <https://github.com/jimidle>
please take a look at this PR, it would help us stop using a fork.
—
Reply to this email directly, view it on GitHub
<#4814 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMC7XMYW55XHLJQ4ES32YUDUZAVCNFSM6AAAAAB2YYL2JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBZGQ3DEMZZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*fsaintjacques* left a comment (antlr/antlr4#4814)
<#4814 (comment)>
@parrt <https://github.com/parrt> & @jimidle <https://github.com/jimidle>
please take a look at this PR, it would help us stop using a fork.
—
Reply to this email directly, view it on GitHub
<#4814 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMC7XMYW55XHLJQ4ES32YUDUZAVCNFSM6AAAAAB2YYL2JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBZGQ3DEMZZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Author
|
@jimidle gentle bump, this would be a really tiny change to merge and would allow us to get rid of some fork cruft. |
Collaborator
|
I will try to put some time on the Go runtime this weekend, though I am somewhat busy. |
|
Any chance this could be merged @jimidle ? |
|
I would also greatly appreciate it if this PR could be merged. |
Member
|
@jimidle if you have time, could you take a look to see if this is correct? Thanks! |
Collaborator
|
I’m on vacation this week. But there are a number of improvements I wish to
add, including tree visitors that currently don’t work as the runtime code
was never implemented and the code gen generates way too much code. I’ll
try to do all this next week
…On Thu, Feb 19, 2026 at 03:30 Terence Parr ***@***.***> wrote:
*parrt* left a comment (antlr/antlr4#4814)
<#4814 (comment)>
@jimidle <https://github.com/jimidle> if you have time, could you take a
look to see if this is correct? Thanks!
—
Reply to this email directly, view it on GitHub
<#4814 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMCHJF2EEBMKZYCUOUT4MTDX7AVCNFSM6AAAAAB2YYL2JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMRTGA2TOMBWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the golang runtime with other languages where the SetTokenSource is publicly available. We require this in our usage of antlr4. We currently have a fork for the sole purpose of this.