Skip to content

Remove Interval internal cache #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+1 −12
Merged

Remove Interval internal cache #4902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions runtime/Java/src/org/antlr/v4/runtime/misc/Interval.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,8 @@

/** An immutable inclusive interval a..b */
public class Interval {
public static final int INTERVAL_POOL_MAX_VALUE = 1000;

public static final Interval INVALID = new Interval(-1,-2);

static final Interval[] cache = new Interval[INTERVAL_POOL_MAX_VALUE+1];

public int a;
public int b;

Expand All @@ -25,14 +21,7 @@ public class Interval {
* have a..a (set with 1 element).
*/
public static Interval of(int a, int b) {
// cache just a..a
if ( a!=b || a<0 || a>INTERVAL_POOL_MAX_VALUE ) {
return new Interval(a,b);
}
if ( cache[a]==null ) {
cache[a] = new Interval(a,a);
}
return cache[a];
return new Interval(a,b);
}

/** return number of elements between a and b inclusively. x..x is length 1.
Expand Down
Loading