ci: Disable checks unrunable @ pre-commit.ci#734
ci: Disable checks unrunable @ pre-commit.ci#734MaxymVlasov merged 2 commits intoantonbabenko:masterfrom
Conversation
webknjaz
changed the title
|
We have pre-commit via GHA, and it runs all hooks specified in .pre-commit-config, not just some of them |
|
Alternatively, there's https://github.com/apps/pre-commit-ci-lite/installations/new + https://pre-commit.ci/lite.html that implements backpushes. |
|
M-m-m, I definitely would suggest to add more context for other contributors, including a brief explanation added as a comment to the code that is changing for future reference and for posterity. |
|
Done. |
MaxymVlasov
changed the title
antonbabenko
left a comment
antonbabenko
left a comment
There was a problem hiding this comment.
@MaxymVlasov I have just installed github app as required
|
pre-commit.ci run |
|
It's not marked as required in branch protection, though. |
|
@webknjaz Updated. |
|
This check is now failing in other PRs and will keep failing until this PR is merged. |
This patch drops the document start and end markers to comply with arbitrary personal preferences. Co-authored-by: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
webknjaz
force-pushed
the
maintenance/pre-commit-ci
branch
from
0053f28 to
7672361
Compare
|
This PR is included in version 1.97.0 🎉 |
4 participants
Put an
xinto the box if that apply:Description of your changes
Enabling faster feedback loop for new contributors by enabling https://pre-commit.ci in this repo.
The only visible effect of this is when said app is installed and the service is running the checks, it would skip the checks that rely on the external executables that might be missing in runtime. It's necessary since that testing environment is controlled by someone else.
How can we test changes
@antonbabenko go to https://github.com/apps/pre-commit-ci/installations/select_target, install the app into this repo and then merge the PR.