chore: Fix shellcheck v0.10.0 linters rules#753
Merged
MaxymVlasov merged 1 commit intomasterfrom Jan 14, 2025
Merged
Conversation
yermulnik
approved these changes
Jan 14, 2025
Owner
|
This PR is included in version 1.97.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Should not change anything, as it just make happy shellcheck v0.10.0 about this particular line
In hooks/_common.sh line 142: ARGS[$arg_idx]=$arg ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. For more information: https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...found in Linters check for unrelated PR #737, as it uses ubutntu24.04, and no matter that
shellcheckrecommend install itself byapt, it contains outdated version for most OSes, IE, ubuntu22.04 uses 0.8.0, when latest one is 0.10.0Actually, we can do it as PATCH release, but I am not sure is it worst it.