Skip to content

Comments

ci: Fix edge case with Nightly builds right after new release#776

Merged
MaxymVlasov merged 2 commits intomasterfrom
ci/fix_nightly_build_corner_case
Jan 23, 2025
Merged

ci: Fix edge case with Nightly builds right after new release#776
MaxymVlasov merged 2 commits intomasterfrom
ci/fix_nightly_build_corner_case

Conversation

@MaxymVlasov
Copy link
Collaborator

@MaxymVlasov MaxymVlasov commented Jan 22, 2025

Description of your changes

Each failed nightly build occurs right when new tag released and tag point to latest commit.

To avoid that, we need to drop tag to HEAD in CI
image
image

How can we test changes

  1. Fork repo with all branches
  2. Create PR from this branch and merge to fork master
  3. Manually make new release
  4. Go to Actions -> Enable ⌛ action
  5. Trigger ⌛ action manually
    https://github.com/MaxymVlasov/pre-commit-terraform-PR776/actions/runs/12916272093

@MaxymVlasov MaxymVlasov marked this pull request as ready for review January 22, 2025 20:16
@MaxymVlasov MaxymVlasov merged commit 9a68d89 into master Jan 23, 2025
66 checks passed
@MaxymVlasov MaxymVlasov deleted the ci/fix_nightly_build_corner_case branch January 23, 2025 11:17
@antonbabenko
Copy link
Owner

This PR is included in version 1.97.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants