chore(yamllint): Allow longer lines to avoid unneeded linter disabling#811
Merged
MaxymVlasov merged 1 commit intomasterfrom Feb 10, 2025
Merged
chore(yamllint): Allow longer lines to avoid unneeded linter disabling#811MaxymVlasov merged 1 commit intomasterfrom
yamllint): Allow longer lines to avoid unneeded linter disabling#811MaxymVlasov merged 1 commit intomasterfrom
Conversation
Formater which will be introduced later, will enforse stricter rules when it possible
WalkthroughThis pull request updates multiple GitHub Actions workflows, container tests, and YAML lint configurations. It adds a new SSH command test, removes various inline yamllint disable comments, and updates several action versions. The CI/CD pipeline has been streamlined by eliminating redundant Python setup and checkout steps and introducing hash calculations for improved caching. Additionally, conditional executions have been added for Docker image builds and release processes, while permissions have been adjusted in select workflows. A new line-length rule has also been introduced in the Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI/CD Workflow
participant PreSetup as Pre-Setup Job
participant Build as Build Job
participant Lint as Lint Job
participant Tests as Tests Job
participant Cache as Cache System
CI->>PreSetup: Trigger pre-setup job
PreSetup->>PreSetup: Calculate hash values (Python & dependencies)
PreSetup->>Cache: Generate cache key
Cache-->>PreSetup: Return cache key
PreSetup->>Lint: Provide cache key outputs
PreSetup->>Tests: Provide cache key outputs
CI->>Build: Continue build (without explicit Python setup/checkout)
sequenceDiagram
participant GH as GitHub Actions
participant Release as Release Job
participant Semantic as Semantic Release Action
GH->>Release: Trigger release event
Release->>Semantic: Run semantic-release with updated permissions
Semantic-->>Release: Create release and comment on issues/pull-requests
Suggested Reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
.github/.container-structure-test-config.yaml(0 hunks).github/workflows/build-image-test.yaml(0 hunks).github/workflows/build-image.yaml(0 hunks).github/workflows/ci-cd.yml(0 hunks).github/workflows/codeql.yml(0 hunks).github/workflows/dependency-review.yml(0 hunks).github/workflows/pr-title.yml(0 hunks).github/workflows/pre-commit.yaml(0 hunks).github/workflows/release.yml(0 hunks).github/workflows/reusable-tox.yml(0 hunks).github/workflows/scorecards.yml(0 hunks).yamllint(1 hunks)
💤 Files with no reviewable changes (11)
- .github/workflows/codeql.yml
- .github/workflows/pre-commit.yaml
- .github/workflows/scorecards.yml
- .github/workflows/build-image-test.yaml
- .github/workflows/build-image.yaml
- .github/.container-structure-test-config.yaml
- .github/workflows/pr-title.yml
- .github/workflows/dependency-review.yml
- .github/workflows/ci-cd.yml
- .github/workflows/release.yml
- .github/workflows/reusable-tox.yml
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: 🧪 Tests / pytest@🐍3.9@windows-2025
- GitHub Check: 🧪 Tests / pytest@🐍3.13@windows-2025
- GitHub Check: 🧪 Tests / pytest@🐍3.12@windows-2025
- GitHub Check: 🧪 Tests / pytest@🐍3.11@windows-2025
- GitHub Check: 🧪 Tests / pytest@🐍3.10@windows-2025
- GitHub Check: 🧪 Tests / pytest@🐍3.10@macos-14
- GitHub Check: 🧹 Linters / pre-commit@🐍3.13@ubuntu-latest
- GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-14
- GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-13
- GitHub Check: 🧪 Tests / pytest@🐍3.13@windows-2025
- GitHub Check: 🧪 Tests / pytest@🐍3.13@macos-14
- GitHub Check: 🧪 Tests / pytest@🐍3.13@macos-13
- GitHub Check: 🧪 Tests / pytest@🐍3.12@windows-2025
- GitHub Check: Ubuntu ARM
- GitHub Check: pre-commit
Comment on lines
+11
to
+12
| line-length: | ||
| max: 100 |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
LGTM! The line-length rule addition aligns with the PR objectives.
Setting max line length to 100 characters is a reasonable choice that:
- Reduces the need for inline linter disabling
- Maintains code readability
- Aligns with common industry practices
Let's verify the impact of this change by checking for any remaining yamllint disable comments:
🏁 Script executed:
#!/bin/bash
# Description: Search for any remaining yamllint disable comments related to line length
# that might need to be removed after this change
rg -i "yamllint disable.*line-length" .github/Length of output: 211
Inline Disables for Line-Length Remain in Workflow Files
The script output shows that inline yamllint disable comments for the line-length rule still exist in the following files:
.github/workflows/build-image-test.yaml.github/workflows/codeql.yml
Since the .yamllint file now enforces a max line length of 100—which aligns with the PR’s objectives to reduce inline linter disabling—please consider removing these inline disable comments if they are no longer needed.
Collaborator
There was a problem hiding this comment.
That's a great use case of AI 👍🏻
@MaxymVlasov FYI ⬆️
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
Collaborator
Author
There was a problem hiding this comment.
Yeah, these 2 comments still exist because these lines > 100. So false-positive, but still nice
yermulnik
approved these changes
Feb 10, 2025
Owner
|
This PR is included in version 1.97.4 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatter which will be introduced later, will enforce stricter rules when it is possible
Summary by CodeRabbit