-
-
Notifications
You must be signed in to change notification settings - Fork 579
fix(terraform_wrapper_module_for_each): Generate right usage example for S3
#952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughDocumentation example source references in the Terraform wrapper module were updated to use placeholder identifiers (MODULE_REPO_ORG, MODULE_REPO_SHORTNAME, MODULE_REPO_PROVIDER, WRAPPER_PATH) instead of concrete S3 bucket module names. No functional or runtime changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the Terraform module wrapper generator was creating a hardcoded S3 bucket example instead of using configurable placeholders that honor the provided variables.
Key Changes
- Replaced hardcoded AWS S3 module references with placeholder variables in the S3 example section
- Ensured the example follows the same pattern as other examples in the documentation template
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
antonbabenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
terraform_wrapper_module_for_each): Generator - S3 example
terraform_wrapper_module_for_each): Generator - S3 exampleterraform_wrapper_module_for_each): Generate right example usage for S3
terraform_wrapper_module_for_each): Generate right example usage for S3terraform_wrapper_module_for_each): Generate right usage example for S3
## [1.104.1](v1.104.0...v1.104.1) (2026-01-04) ### Bug Fixes * **`terraform_wrapper_module_for_each`:** Generate right usage example for S3 ([#952](#952)) ([3117fe2](3117fe2))
|
This PR is included in version 1.104.1 🎉 |
Description of your changes
The generator of Terraform module wrappers will create a fixed example and will not honor variables.
How can we test changes
This will generate a fixed example like this:
After this PR, the source examples should be like other examples