adding a new workflow to validate the FlexibleIPAM feature#6879
Merged
antoninbas merged 1 commit intoantrea-io:mainfrom Feb 10, 2025
Merged
adding a new workflow to validate the FlexibleIPAM feature#6879antoninbas merged 1 commit intoantrea-io:mainfrom
antoninbas merged 1 commit intoantrea-io:mainfrom
Conversation
KMAnju-2021
force-pushed
the
add-cncf-runners
branch
from
ccdc56f to
ef95db6
Compare
rajnkamr
reviewed
Dec 24, 2024
rajnkamr
reviewed
Dec 24, 2024
rajnkamr
reviewed
Dec 24, 2024
KMAnju-2021
force-pushed
the
add-cncf-runners
branch
22 times, most recently
from
33a2b50 to
9486da3
Compare
antoninbas
reviewed
Jan 2, 2025
Contributor
antoninbas
left a comment
antoninbas
left a comment
There was a problem hiding this comment.
The title of the PR is misleading: we are adding a new workflow to validate the FlexibleIPAM feature. The fact that we use a non-default runner is an "implementation detail".
KMAnju-2021
changed the title
KMAnju-2021
force-pushed
the
add-cncf-runners
branch
from
ebeb982 to
32595a9
Compare
KMAnju-2021
changed the title
antoninbas
reviewed
Jan 21, 2025
KMAnju-2021
force-pushed
the
add-cncf-runners
branch
10 times, most recently
from
ea9f595 to
60f4442
Compare
antoninbas
reviewed
Jan 27, 2025
antoninbas
reviewed
Feb 5, 2025
Contributor
antoninbas
left a comment
antoninbas
left a comment
There was a problem hiding this comment.
a few more small comments, but getting there
Signed-off-by: KMAnju-2021 <km074btcse18@igdtuw.ac.in>
antoninbas
approved these changes
Feb 10, 2025
Contributor
antoninbas
left a comment
antoninbas
left a comment
There was a problem hiding this comment.
LGTM, thanks for making the changes
Contributor
|
/skip-all |
Contributor
|
@KMAnju-2021 any plan to disable / remove the jenkins job after this is merged? |
1 task
This was referenced Mar 12, 2025
Closed
This was referenced May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6887