Use synctest for TestNewTracker in pkg/agent/nodeip#7822
Open
antoninbas wants to merge 1 commit intomainfrom
Open
Use synctest for TestNewTracker in pkg/agent/nodeip#7822antoninbas wants to merge 1 commit intomainfrom
antoninbas wants to merge 1 commit intomainfrom
Conversation
Instead of relying on polling (with `assert.Eventually`). The motivation for this change is that we observed a test failure in CI. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR replaces polling-based test synchronization (assert.EventuallyWithT with a 2-second timeout and 10ms polling interval) with the deterministic testing/synctest package in TestNewTracker. This resolves a flaky CI failure caused by timing sensitivity in the original approach.
Changes:
- Wrap
TestNewTrackerbody insynctest.Testto create a controlled goroutine bubble. - Replace
assert.EventuallyWithTcalls withsynctest.Wait()for deterministic synchronization after Create/Update/Delete operations. - Add proper error checking (
require.NoError) for Kubernetes API calls that were previously unchecked.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on polling (with
assert.Eventually). The motivation for this change is that we observed a test failure in CI.