Conversation
Summary of ChangesHello @huaxiabuluo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where annotation lines in pie charts could obscure the chart itself. The core fix involves refining the label positioning logic by sorting labels vertically before rendering, which significantly reduces overlaps. Additionally, a new test case has been introduced to validate the behavior of spider-type pie labels when handling data slices with zero values, thereby enhancing the overall stability and correctness of the component's rendering. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| let delta; | ||
|
|
||
| half.forEach((label) => { | ||
| const sortedHalf = half.sort((a, b) => a.y - b.y); |
There was a problem hiding this comment.
sort() 方法会对数组进行原地排序，这意味着作为参数传入的 half 数组被修改了。这是一个副作用，如果代码的其他部分依赖于 half 数组的原始顺序，可能会导致难以发现的 bug。最佳实践是函数不应修改其输入，除非这是其明确的目的。你可以在排序前创建一个数组的浅拷贝来避免这个问题。
| const sortedHalf = half.sort((a, b) => a.y - b.y); | |
| const sortedHalf = [...half].sort((a, b) => a.y - b.y); |
Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: |
There was a problem hiding this comment.
效果上是不是应该在左上边，因为是最后一个数据，第一个数据是0的话应该在右边（第一象限）
| let delta; | ||
|
|
||
| half.forEach((label) => { | ||
| const sortedHalf = half.sort((a, b) => a.y - b.y); |
There was a problem hiding this comment.
这样可以绕过去，但感觉应该改锚点角度 锚点坐标那边？两种布局应该都有这个问题
huaxiabuluo
force-pushed
the
fix-pielabel-occlusion
branch
from
40eec53 to
b551db7
Compare
| const inflectionPoint = getEndPoint(center, anchorAngle, radius + inflectionOffset); | ||
| // 锚点方向 | ||
| const side = anchorPoint.x < center.x ? 'left' : 'right'; | ||
| const side = anchorPoint.x <= center.x ? 'left' : 'right'; |
There was a problem hiding this comment.
这样改第一个数据也会变到左边。但标签应该是有顺序的，从右边（第一象限）绕一圈到左边第四象限
2 participants
No description provided.