docs: fix label callback type signatures inconsistency in axis docs#7283
Merged
moayuisuda merged 1 commit intov5from Mar 27, 2026
Merged
docs: fix label callback type signatures inconsistency in axis docs#7283moayuisuda merged 1 commit intov5from
moayuisuda merged 1 commit intov5from
Conversation
…#7268) Agent-Logs-Url: https://github.com/antvis/G2/sessions/34c17969-935e-4180-9c6c-b7fd2e99ce12 Co-authored-by: moayuisuda <37040897+moayuisuda@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
moayuisuda
March 27, 2026 08:07
View session
moayuisuda
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #7268 aligned
computeLabelsBBoxto pass the fulllabelsarray as the third argument to label style callbacks — matching the render phase behavior. The docs had a leftover inconsistency:labelFormatterandlabelRendershowed(datum, index, array)while every other label style property (labelFontSize,labelFill, etc.) used(datum, index, data).Changes
axis.en.md/axis.zh.md: NormalizelabelFormatterandlabelRendertype signatures from(datum, index, array) => string→(datum, index, data) => stringAll label style callbacks now consistently accept: