-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: One edge will not have parallel edges(transforms/process-parallel-edges) #7546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5
Are you sure you want to change the base?
fix: One edge will not have parallel edges(transforms/process-parallel-edges) #7546
Conversation
Summary of ChangesHello @rubbishmaker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a fix to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
你好,感谢你的贡献。这个修复是正确的,它解决了当两个节点之间只有一条边时,该边仍被作为平行边处理的问题。通过在 length === 1 的情况下直接 return,可以避免不必要地修改边的样式,这符合“不处理单个边”的预期行为。
我有一个关于此更改引入的行为变化的评论,请查看。
| style.loopDist = Math.floor(i / len) * distance + 50; | ||
| } else if (length === 1) { | ||
| style.curveOffset = 0; | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个行为变化是符合预期的吧,不管怎么样,当只有一条边的时候始终使用配置的样式,不进入平行边处理
当两个节点之间只有一条边时,不应该进入平行边的transform处理。#7477