Skip to content

chore: prefix all routes with account #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ebadi
Copy link
Contributor

@ebadi ebadi commented Aug 6, 2025

Description

No new functionality is added. Only all Flask routes have been updated to start with the /account prefix.
Example:

  • /login -> /account/login
  • /profile -> /account/profile

This change was made to simplify Nginx reverse proxy configuration and provide a single entry point for account-related endpoints. This also makes it possible for Nginx to serve static content (js, css, images) directly via nginx (instead of routing it through Flask), here is a sample nginx.conf

server {
        listen       80;
        server_name  localhost;

        location /account/ {
                proxy_pass http://app:5000/account/;
                proxy_set_header Host $host;
                proxy_set_header X-Real-IP $remote_addr;
                proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
                proxy_set_header X-Forwarded-Proto $scheme;
        }
        location /static {
                root /var/www/front-end/; 
        }

}

Fixes # (issue)

No functionality is added.

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue).

[ ] New feature (non-breaking change which adds functionality).

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Inside docker

[x ] My code follows the style guidelines of this project.

[x ] I have performed a self-review of my own code.

[ x] I have commented my code, particularly in hard-to-understand areas.

[ x] I have made corresponding changes to the documentation.

[ x] My changes generate no new warnings.

[ ] I have added tests that prove my fix is effective or that my feature works.

[? ] New and existing unit tests pass locally with my changes.

[ x] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant