Skip to content

Added a simple feature of width in card used to display fix for #4258 #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added a simple feature of width in card used to display fix for #4258 #4341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/cards/top-languages-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,9 +409,10 @@ const renderCompactLayout = (langs, width, totalLanguageSize, hideProgress) => {
* @param {number} totalLanguageSize Total size of all languages.
* @returns {string} Compact layout card SVG object.
*/
const renderDonutVerticalLayout = (langs, totalLanguageSize) => {
const renderDonutVerticalLayout = (langs, totalLanguageSize, width = 300) => {
// Donut vertical chart radius and total length
const radius = 80;
const centerX = width / 2;
const radius = Math.max(60, width / 3.5);
const totalCircleLength = getCircleLength(radius);

// SVG circles
Expand All @@ -432,7 +433,7 @@ const renderDonutVerticalLayout = (langs, totalLanguageSize) => {
circles.push(`
<g class="stagger" style="animation-delay: ${delay}ms">
<circle
cx="150"
cx="${centerX}"
cy="100"
r="${radius}"
fill="transparent"
Expand Down Expand Up @@ -779,10 +780,10 @@ const renderTopLanguages = (topLangs, options = {}) => {
});
} else if (layout === "pie") {
height = calculatePieLayoutHeight(langs.length);
finalLayout = renderPieLayout(langs, totalLanguageSize);
finalLayout = `<svg width="${width}" height="${height}">${renderPieLayout(langs, totalLanguageSize)}</svg>`;
} else if (layout === "donut-vertical") {
height = calculateDonutVerticalLayoutHeight(langs.length);
finalLayout = renderDonutVerticalLayout(langs, totalLanguageSize);
finalLayout = `<svg width="${width}" height="${height}">${renderDonutVerticalLayout(langs, totalLanguageSize, width)}</svg>`;
} else if (layout === "compact" || hide_progress == true) {
height =
calculateCompactLayoutHeight(langs.length) + (hide_progress ? -25 : 0);
Expand Down Expand Up @@ -864,7 +865,7 @@ const renderTopLanguages = (topLangs, options = {}) => {
}

return card.render(`
<svg data-testid="lang-items" x="${CARD_PADDING}">
<svg data-testid="lang-items" x="${CARD_PADDING}" width="${width}">
${finalLayout}
</svg>
`);
Expand Down