-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
fix: Wakatime compact card display #4435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…g in Wakatime cards.
…r improved spacing
@bbbugg is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bbbugg
Thank you for opening pull request. I appreciate you interest in our project.
Regarding the changes, the wakatime card works as is for years and thousands of users are okay with current behavior. This means that we definitely should not change the default baviour of the card. For preventing users to experience unexpected changes in their profiles withour actions from their side let's keep it as is.
However, I'm open to consider the addition of new query string parameter, for example &ordering=horizontal | vertical
, to provide more customization ways for users who really wants it.
Also I didn't get the changes related to the line height, I would be grateful in case you can explain in more details.
Thank you for your review! About the line height changes: Previously, both the line spacing and the overall card height were determined by a fixed value of 25, so the line_height parameter had no real effect. In this PR, the spacing between lines and the card height are now both dynamically calculated based on the line_height parameter, making it actually functional. Additionally, the ordering logic has been refactored to use the |
…s (horizontal/vertical)
# Conflicts: # src/cards/wakatime.js
This pull request updates the layout logic for rendering the compact Wakatime card, focusing on improving the spacing and alignment of language nodes. The main changes introduce a configurable
lineHeight
parameter, ensuring better vertical spacing and more maintainable code when displaying language statistics.What’s changed
horizontal
.Examples
Horizontal ordering:
Vertical ordering:
Larger line height (35):
Smaller line height (15):