fix: prevent TypeError crashes on network errors with safe property a… #4511
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccess Fixed critical bug where accessing err.response.data without null checks caused TypeError crashes when network errors occurred (timeouts, DNS failures, connection refused). These errors don't have err.response property. Changes: - src/common/retryer.js: Use optional chaining for err.response.data access - src/fetchers/wakatime.js: Use optional chaining for err.response.status - tests/retryer.test.js: Add test coverage for network error scenarios Fixes crashes with "Cannot read property 'data' of undefined" and ensures graceful error handling during network instability.
|
@mithun50 is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4510
Fixed critical bug where accessing err.response.data without null checks caused TypeError crashes when network errors occurred (timeouts, DNS failures, connection refused). These errors don't have err.response property.
Changes:
Fixes crashes with "Cannot read property 'data' of undefined" and ensures graceful error handling during network instability.