reduce magic numbers #4534
Open
reduce magic numbers #4534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martin-mfg is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing the magic numbers in
src/cards/wakatime.jsas requested here.While working on this I realized that the line
let width = normalizedWidth - 5;doesn't make sense imo. The corresponding logic was originally introduced here, where width was set to 490 but the card width was set to 495 (in line 211). I think this was an accident back then. Indeed, when measuring pixels in the generated SVG, the progress bar is not quite centered, because it's 5px too short. This is why I removed the linelet width = normalizedWidth - 5;in this PR.old version, asymmetric progress bar
new version, symmetric progress bar:
