fix: correct CJK text wrapping logic (#4678) #4757
Open
+1,405
−6,446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the CJK (Chinese, Japanese, Korean) text overflow issue in repository cards, as reported in #4678.
The previous logic relied on a third-party library (
word-wrap) and specific punctuation (full-width commas), which failed to account for the actual visual width of CJK characters in SVG rendering. This caused text to break the card boundaries or fail to wrap entirely when no punctuation was present.Key Changes
maxLineswith an ellipsis (...) for truncated text.word-wraplibrary as the new custom logic is more accurate and reduces unnecessary dependencies.Screenshots (Before & After)
Test Results
Passed all 11 tests in
tests/fmt.test.js, including the newly added CJK wrapping scenarios.Note on lockfile
package-lock.jsonwas updated to reflect the removal ofword-wrapand to align with the Node.js v22 environment.