fix: add Primer Octicons license attribution for SVG paths#4842
Open
NETIZEN-11 wants to merge 3 commits intoanuraghazra:masterfrom
Open
fix: add Primer Octicons license attribution for SVG paths#4842NETIZEN-11 wants to merge 3 commits intoanuraghazra:masterfrom
NETIZEN-11 wants to merge 3 commits intoanuraghazra:masterfrom
Conversation
- Add NOTICE file with Primer Octicons copyright and license information - Add attribution comment in icons.js file - Ensure MIT License compliance for SVG path data Resolves licensing compliance issue for Primer Octicons usage.
|
Someone is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
added 2 commits
March 27, 2026 00:46
…e text - Add complete MIT License text in NOTICE file as required by the license - Add source URL reference to primer/octicons repository - Improve attribution comment in icons.js with JSDoc format and source link Resolves anuraghazra#4839
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4839
This PR adds the required license attribution for SVG paths used in
src/common/icons.js, which are sourced from Primer Octicons.Since Primer Octicons is licensed under the MIT License, it requires inclusion of the copyright and permission notice. This attribution was previously missing from the repository.
To address this, a NOTICE file has been added with the appropriate attribution.
This change is limited to license compliance only and does not affect any functionality.