fix: handle nested default exports in Node.js 23+ #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Node.js 23 and later, dynamically importing a CommonJS module that
was transpiled by Babel results in a different module structure than in
earlier versions. The structure becomes:
```js
{ __esModule: true, default: { default: [Function] }, 'module.exports': { ... } }
```
This caused the "arrangeData is not a function" error because the
existing dynamicImport() function only handled cases with exactly 2 keys,
but Node.js 23+ adds a 'module.exports' key (3 keys total).
Changes:
- Updated dynamicImport() in utils.js to detect and handle the Node.js 23+
module structure by checking for the presence of module.exports
- Refactored index.js to apply takeDefaultExport() immediately to both
the default and custom data arrangers for consistency
This fix is backward compatible with older Node.js versions and
addresses the TypeError that occurred when running spectaql with Node.js
v23+.
Fixes anvilco#1001.
Signed-off-by: Davide Briani <[email protected]>
|
Would be great if we can get that merged please. 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node.js 23 and later, dynamically importing a CommonJS module that was transpiled by Babel results in a different module structure than in earlier versions. The structure becomes:
This caused the "arrangeData is not a function" error because the existing dynamicImport() function only handled cases with exactly 2 keys, but Node.js 23+ adds a 'module.exports' key (3 keys total).
Changes:
This fix is backward compatible with older Node.js versions and addresses the TypeError that occurred when running spectaql with Node.js v23+.
Fixes #1001.