Draft
Conversation
changes top-down order: - fix VariableOrderWrong - mask all unstated arches - abi_86_32 is impossible on them - remove @System packages from DEPENDs - inline x86? clause - move games-util/esteam to bigger !steamruntime? clause Signed-off-by: Filip Kobierski <fkobi@pm.me>
fkobi
force-pushed
the
better-launcher-ebuild
branch
from
35ddee9 to
527302f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are in the commit message.
What I think would be beneficial is having
{gcc,glibc}[multilib]plainly in DEPENDs bit pkgcheck does not like that:vs current:
NonsolvableDepsInDev: version 1.0.0.81: nonsolvable depset(rdepend) keyword(~x86) dev profile (default/linux/x86/23.0/i486/musl) (8 total): solutions: [ >=sys-libs/glibc-2.15 ]Paul Zander advised that those could be silenced with
pkgcheck.conflike the sci overlay does. I think it is worth considering.Also zenity logic for the postinst message could be improved (I think having it as an optfeature would be the best) but I am not sure how.
To try do that those questions need to be answered:
USE=steamruntime? Why?