fix NoCrossover missing offsprings

[gideonoludeyi]

Resolves #743

NoCrossover does random selection which fails to propagate certain parents.
This PR ensures that all parents are propagated as offsprings.

Thanks @oxinabox for the catch.

[gideonoludeyi]

Any updates on approving this change. The failing tests seemed to have failed due to external causes. Might be worth retrying the CI action to verify.

[blankjul]

can you check if the commit above also fixes this issue?

[oxinabox]

can you check if the commit above also fixes this issue?

It does not

Consider if you have 3 osprint and 2 parents.
Then that means we will chose with replacement 3 items from a list of 3.

Consider the example that the parents are [1, 2]
Then sampling with replacement still allows it to be possible to chose 1 three times or 2 three times.
Which means that not all parents surivive.

[blankjul]

okay second attempt. what do you think about the new implementation? covering all the cases depending on n_offsprings.

[gideonoludeyi]

I think it's good.

Should be safe to close this PR.