Closed
Conversation
MohitMandalia
requested review from
konstantiniiv and
uburoiubu
as code owners
Author
|
Raising a single pr for all the tests for feature-ui-settings module to avoid pr noise can split when in review |
Collaborator
|
Hi, thanks for the PRs, but I have to cancel them. There’s no need to write tests for this code — they’re hard to maintain, and these PRs are already outdated. This month we’ll be updating our approach to opening pull requests. Thanks for your understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ViewModel tests for feature-ui-settings module
What type of PR is this? (check all applicable)
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?