Fixed CSS relative path imports in style.css loading #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirottu
requested changes
Dec 21, 2025
Author
|
Fair enough, I have swapped fs::read_to_string() to Path::new().exists(), and re-tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for relative paths when using '@import' in style.css.
Problem
When using '@import' in style.css, relative paths fail because 'load_from_string()' does not provide GTK with file context, and thus relative paths become un-resolve-able.
Solution
Changed css_provider.load_from_string() to css_provider.load_from_path(), which provides the necessary path context under the hood.
Texting/Verification
Verified url style imports, absolute paths, and relative paths, didn't break anything, and now I can @import "./colors.css" without issue. Was this necessary? No. Do I hope you merge it? Yes, pretty please.