Skip to content

feat: Add support for CloudKeeper Anyscale services#69

Merged
hongchaodeng merged 3 commits intomainfrom
brent/upd-iam-serv-perm
Jul 24, 2025
Merged

feat: Add support for CloudKeeper Anyscale services#69
hongchaodeng merged 3 commits intomainfrom
brent/upd-iam-serv-perm

Conversation

@brent-anyscale
Copy link
Collaborator

@brent-anyscale brent-anyscale commented Jul 19, 2025

  • Moved Anyscale Services V2 policy to a new template
  • Added support for CloudKeeper Anyscale services
  • Added flag to enable/disable the creation of the ELB Service Linked Role
  • Should fix Issue [bug]: Deprecation warning in IAM module #68 (AWS TF Provider 6.0+ has not gone through additional testing)

On branch brent/upd-iam-serv-perm
Changes to be committed:
modified: CHANGELOG.md
modified: README.md
modified: getting-started.md
modified: main.tf
modified: modules/aws-anyscale-iam/README.md
new file: modules/aws-anyscale-iam/anyscale-control_plane-services-v2.tmpl
modified: modules/aws-anyscale-iam/iam-policies-data.tf
modified: modules/aws-anyscale-iam/variables.tf
modified: variables.tf

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

- Moved Anyscale Services V2 policy to a new template
- Added support for CloudKeeper Anyscale services
- Added flag to enable/disable the creation of the ELB Service Linked Role

On branch brent/upd-iam-serv-perm
Changes to be committed:
	modified:   CHANGELOG.md
	modified:   README.md
	modified:   getting-started.md
	modified:   main.tf
	modified:   modules/aws-anyscale-iam/README.md
	new file:   modules/aws-anyscale-iam/anyscale-control_plane-services-v2.tmpl
	modified:   modules/aws-anyscale-iam/iam-policies-data.tf
	modified:   modules/aws-anyscale-iam/variables.tf
	modified:   variables.tf
@brent-anyscale brent-anyscale requested a review from a team as a code owner July 19, 2025 01:00
@github-actions github-actions bot added documentation Improvements or additions to documentation terraform labels Jul 19, 2025
@brent-anyscale brent-anyscale added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Jul 19, 2025
Remove the region from the IAM Role descriptions.
With the new AWS provider, the call to the data source to return the region introduced
a deprecation warning. As this is rarely required, it is being removed and the region
will not be part of the IAM Role descriptions.

Changes to be committed:
	modified:   modules/aws-anyscale-iam/README.md
	modified:   modules/aws-anyscale-iam/eks-iam-main.tf
	modified:   modules/aws-anyscale-iam/main.tf
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 19, 2025
Changes to be committed:
	modified:   .tflint.hcl
@hongchaodeng hongchaodeng merged commit 4d40535 into main Jul 24, 2025
4 checks passed
@hongchaodeng hongchaodeng deleted the brent/upd-iam-serv-perm branch July 24, 2025 17:26
hongchaodeng pushed a commit that referenced this pull request Sep 8, 2025
* feat: Add support for CloudKeeper Anyscale services

- Moved Anyscale Services V2 policy to a new template
- Added support for CloudKeeper Anyscale services
- Added flag to enable/disable the creation of the ELB Service Linked Role

On branch brent/upd-iam-serv-perm
Changes to be committed:
	modified:   CHANGELOG.md
	modified:   README.md
	modified:   getting-started.md
	modified:   main.tf
	modified:   modules/aws-anyscale-iam/README.md
	new file:   modules/aws-anyscale-iam/anyscale-control_plane-services-v2.tmpl
	modified:   modules/aws-anyscale-iam/iam-policies-data.tf
	modified:   modules/aws-anyscale-iam/variables.tf
	modified:   variables.tf

* upd: IAM Role descriptions

Remove the region from the IAM Role descriptions.
With the new AWS provider, the call to the data source to return the region introduced
a deprecation warning. As this is rarely required, it is being removed and the region
will not be part of the IAM Role descriptions.

Changes to be committed:
	modified:   modules/aws-anyscale-iam/README.md
	modified:   modules/aws-anyscale-iam/eks-iam-main.tf
	modified:   modules/aws-anyscale-iam/main.tf

* upd: add tflint rule to skip tmpl files

Changes to be committed:
	modified:   .tflint.hcl
hongchaodeng pushed a commit that referenced this pull request Sep 10, 2025
* feat: Add support for CloudKeeper Anyscale services

- Moved Anyscale Services V2 policy to a new template
- Added support for CloudKeeper Anyscale services
- Added flag to enable/disable the creation of the ELB Service Linked Role

On branch brent/upd-iam-serv-perm
Changes to be committed:
	modified:   CHANGELOG.md
	modified:   README.md
	modified:   getting-started.md
	modified:   main.tf
	modified:   modules/aws-anyscale-iam/README.md
	new file:   modules/aws-anyscale-iam/anyscale-control_plane-services-v2.tmpl
	modified:   modules/aws-anyscale-iam/iam-policies-data.tf
	modified:   modules/aws-anyscale-iam/variables.tf
	modified:   variables.tf

* upd: IAM Role descriptions

Remove the region from the IAM Role descriptions.
With the new AWS provider, the call to the data source to return the region introduced
a deprecation warning. As this is rarely required, it is being removed and the region
will not be part of the IAM Role descriptions.

Changes to be committed:
	modified:   modules/aws-anyscale-iam/README.md
	modified:   modules/aws-anyscale-iam/eks-iam-main.tf
	modified:   modules/aws-anyscale-iam/main.tf

* upd: add tflint rule to skip tmpl files

Changes to be committed:
	modified:   .tflint.hcl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request terraform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants