Change default value of attach_policy to false in the description#87
Merged
brent-anyscale merged 1 commit intomainfrom Feb 3, 2026
Merged
Change default value of attach_policy to false in the description#87brent-anyscale merged 1 commit intomainfrom
brent-anyscale merged 1 commit intomainfrom
Conversation
default is false, but description says otherwise.
jpatra72
changed the title
brent-anyscale
approved these changes
Feb 3, 2026
Collaborator
brent-anyscale
left a comment
brent-anyscale
left a comment
There was a problem hiding this comment.
Thanks for catching this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default is false, but description says otherwise.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?
Other information