Skip to content

Add CORS to Azure bucket storage#52

Merged
brycehuang30 merged 1 commit intomainfrom
bhuang/update-cors
Jan 22, 2026
Merged

Add CORS to Azure bucket storage#52
brycehuang30 merged 1 commit intomainfrom
bhuang/update-cors

Conversation

@brycehuang30
Copy link
Contributor

@brycehuang30 brycehuang30 commented Jan 15, 2026

Changes

This PR adds blob storage CORS config for Azure cloud, to codify the existing CORS + required CORS for enabling partial read from blob object (to support Optimized File Viewer).

S3 config is updated here: anyscale/terraform-aws-anyscale-cloudfoundation-modules#86
GCS config already has it; doesn't require update: https://github.com/anyscale/terraform-google-anyscale-cloudfoundation-modules/blob/main/modules/google-anyscale-cloudstorage/variables.tf#L233-L240

Test

$ terraform plan
...

      + blob_properties {
          + change_feed_enabled      = false
          + default_service_version  = (known after apply)
          + last_access_time_enabled = false
          + versioning_enabled       = false

          + cors_rule {
              + allowed_headers    = [
                  + "*",
                ]
              + allowed_methods    = [
                  + "GET",
                  + "POST",
                  + "PUT",
                  + "HEAD",
                  + "DELETE",
                ]
              + allowed_origins    = [
                  + "https://*.anyscale.com",
                ]
              + exposed_headers    = [
                  + "Accept-Ranges",
                  + "Content-Range",
                  + "Content-Length",
                ]
              + max_age_in_seconds = 0
            }
        }
...

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@brycehuang30 brycehuang30 marked this pull request as draft January 15, 2026 19:19
@github-actions github-actions bot added documentation Improvements or additions to documentation examples labels Jan 15, 2026
@brent-anyscale brent-anyscale self-requested a review January 21, 2026 01:09
Copy link
Collaborator

@brent-anyscale brent-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brycehuang30 brycehuang30 marked this pull request as ready for review January 22, 2026 08:49
@brycehuang30 brycehuang30 merged commit e6104f0 into main Jan 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants