Skip to content

Conversation

joncinque
Copy link

Problem

The stake redelegate instruction will not enabled in its current state.

Summary of Changes

Since it's been part of the SDK and used downstream, it's a bit finnicky to just deprecate and remove, so here's what was done:

  • sdk: deprecate the instruction and stake flag without deprecating the stake flags as a whole
  • cli: remove the new command
  • program: remove the instruction processor, and all logic that uses the feature gate and stake flag
  • transaction-status: keep the instruction parser

Fixes #

Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the feature definition?

Generally, this looks good to me. Two small questions.

@joncinque
Copy link
Author

Should we remove the feature definition?

I thought we kept around feature flags for longer to check when things were enabled, but since it was never enabled, you're right, it's probably better to just remove it.

@joncinque joncinque requested a review from CriesofCarrots July 19, 2024 22:36
Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once ci is happy!

@joncinque joncinque requested a review from topointon-jump July 22, 2024 11:02
@2501babe
Copy link
Member

super excited for this, will review tomorrow

@joncinque
Copy link
Author

@CriesofCarrots, in case you wanted to approve, I just rebased after landing solana-labs/solana-program-library#7033, no other changes

@joncinque
Copy link
Author

Dang, you beat me to it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants