Skip to content

v2.2: Feature - UpgradeableLoaderInstruction::ExtendProgramChecked (backport of #6131)#6217

Merged
Lichtso merged 1 commit intov2.2from
mergify/bp/v2.2/pr-6131
Jun 6, 2025
Merged

v2.2: Feature - UpgradeableLoaderInstruction::ExtendProgramChecked (backport of #6131)#6217
Lichtso merged 1 commit intov2.2from
mergify/bp/v2.2/pr-6131

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented May 13, 2025

See SIMD-0164.

Feature Gate Issue: #87


This is an automatic backport of pull request #6131 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner May 13, 2025 13:59
@mergify mergify bot added the conflicts label May 13, 2025
@mergify
Copy link
Copy Markdown
Author

mergify bot commented May 13, 2025

Cherry-pick of 94d70cd has failed:

On branch mergify/bp/v2.2/pr-6131
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit 94d70cdf4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Cargo.toml
	modified:   cli/Cargo.toml
	modified:   cli/src/program.rs
	modified:   cli/tests/program.rs
	modified:   programs/bpf_loader/src/lib.rs
	modified:   transaction-status/src/parse_bpf_loader.rs

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   Cargo.lock
	both modified:   feature-set/src/lib.rs
	both modified:   genesis/Cargo.toml
	both modified:   programs/bpf-loader-tests/tests/extend_program_ix.rs
	both modified:   programs/sbf/Cargo.lock
	both modified:   programs/sbf/Cargo.toml
	both modified:   runtime/Cargo.toml
	deleted by us:   svm-feature-set/src/lib.rs
	both modified:   svm/Cargo.toml
	both modified:   svm/examples/Cargo.lock
	both modified:   transaction-status/Cargo.toml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify
Copy link
Copy Markdown
Author

mergify bot commented May 13, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6131 branch from ec81125 to 17f6683 Compare May 13, 2025 15:00
@Lichtso Lichtso removed the conflicts label May 13, 2025
@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6131 branch from 17f6683 to 97726e8 Compare May 13, 2025 15:08
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 13, 2025

Codecov Report

Attention: Patch coverage is 5.26316% with 234 lines in your changes missing coverage. Please review.

Project coverage is 83.4%. Comparing base (98c6de1) to head (14ae250).

Additional details and impacted files
@@            Coverage Diff            @@
##             v2.2    #6217     +/-   ##
=========================================
- Coverage    83.4%    83.4%   -0.1%     
=========================================
  Files         807      807             
  Lines      373380   373478     +98     
=========================================
+ Hits       311484   311501     +17     
- Misses      61896    61977     +81     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6131 branch from 97726e8 to 28ee37c Compare May 15, 2025 14:19
@Lichtso Lichtso requested a review from buffalojoec May 15, 2025 15:54
@Lichtso Lichtso changed the title v2.2: Feature - UpgradeableLoaderInstruction::ExtendProgramChecked (backport of #6131) v2.2: Feature - UpgradeableLoaderInstruction::ExtendProgramChecked (backport of #6131 and #6245) May 16, 2025
@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6131 branch from 28ee37c to ca5aa93 Compare May 16, 2025 13:23
buffalojoec
buffalojoec previously approved these changes May 17, 2025
t-nelson
t-nelson previously approved these changes May 28, 2025
Copy link
Copy Markdown

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with #6337 bp to follow

@Lichtso Lichtso requested a review from buffalojoec June 2, 2025 17:16
@t-nelson
Copy link
Copy Markdown

t-nelson commented Jun 3, 2025

#6337 should go in on its own, not here. never bp two prs in one

* Bumps solana-loader-v3-interface version.

* Adds the feature.

* Adds feature gating logic.

* Adjusts transaction-status parser.

* Adjusts CLI manual extend and auto extend.

* Adds authority_signer_index to ProgramCliCommand::ExtendProgramChecked.

* Adjusts solana-bpf-loader-program-tests.

(cherry picked from commit 94d70cd)
@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6131 branch from ca5aa93 to 07e650a Compare June 4, 2025 07:11
@Lichtso Lichtso requested a review from t-nelson June 4, 2025 09:37
@Lichtso Lichtso changed the title v2.2: Feature - UpgradeableLoaderInstruction::ExtendProgramChecked (backport of #6131 and #6245) v2.2: Feature - UpgradeableLoaderInstruction::ExtendProgramChecked (backport of #6131) Jun 4, 2025
@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6131 branch from 07e650a to 14ae250 Compare June 4, 2025 09:39
@buffalojoec
Copy link
Copy Markdown

#6337 should go in on its own, not here. never bp two prs in one

This is already a BP of two PRs

@Lichtso
Copy link
Copy Markdown

Lichtso commented Jun 6, 2025

I removed the second, we will do that individually.

@Lichtso Lichtso merged commit 3f8a2a8 into v2.2 Jun 6, 2025
46 checks passed
@Lichtso Lichtso deleted the mergify/bp/v2.2/pr-6131 branch June 6, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants