Merged
Conversation
ksn6
force-pushed
the
alpenglow-clock-checks
branch
2 times, most recently
from
310473c to
53574b6
Compare
ksn6
force-pushed
the
alpenglow-clock-checks
branch
from
fb24e0b to
029c973
Compare
ksn6
force-pushed
the
alpenglow-clock-checks
branch
from
029c973 to
e781f0d
Compare
AshwinSekar
reviewed
Nov 12, 2025
wen-coding
reviewed
Nov 12, 2025
AshwinSekar
reviewed
Nov 12, 2025
AshwinSekar
reviewed
Nov 13, 2025
Contributor
AshwinSekar
left a comment
AshwinSekar
left a comment
There was a problem hiding this comment.
nice work just a small nit
wen-coding
approved these changes
Nov 13, 2025
AshwinSekar
reviewed
Nov 13, 2025
| // Produce the footer with the current timestamp | ||
| let working_bank = w_poh_recorder.working_bank().unwrap(); | ||
| let footer = produce_block_footer(working_bank); | ||
| let footer = produce_block_footer(working_bank.bank.clone_without_scheduler()); |
Contributor
There was a problem hiding this comment.
oh i meant you already have bank above, so we don't need to grab the working_bank() anymore since they are the same thing, so you could use bank here and below in update_bank_with_footer
Contributor
Author
There was a problem hiding this comment.
oh true - will fix in a separate pr
AshwinSekar
pushed a commit
to AshwinSekar/alpenglow
that referenced
this pull request
Feb 23, 2026
We enforce Alpenglow clock checks, outlined in detail here: solana-foundation/solana-improvement-documents#363.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and Summary of Changes
We enforce Alpenglow clock checks, outlined in detail here: solana-foundation/solana-improvement-documents#363.