Safer Account

[Buzzec]

Added safer code for Account. Removed copy and clone from Account. Changed lamports functions to operate on a Cell.

Should also be a bit more efficient in a few places.

[sonicfromnewyoke]

overall idea is nice

however to me it looks like this MR can be split into 3-4 smaller ones

[Buzzec]

Going to stack another PR to optimize the data locking now that lamports doesn't use it

[Buzzec]

Going to stack another PR to optimize the data locking now that lamports doesn't use it

Stacked PR: staratlasmeta#1

[febo]

@Buzzec This is great, thank you! Could you please bump the solana cli version to 2.3.0 here: https://github.com/anza-xyz/pinocchio/blob/main/Cargo.toml#L31

This will bump the rust version used in CI to 1.84.1.

[Buzzec]

@Buzzec This is great, thank you! Could you please bump the solana cli version to 2.3.0 here: https://github.com/anza-xyz/pinocchio/blob/main/Cargo.toml#L31

This will bump the rust version used in CI to 1.84.1.

Done

[Buzzec]

With 1.84 we can fix the Miri issues as well, will do that in another PR

[febo]

With 1.84 we can fix the Miri issues as well, will do that in another PR

Good point – separate PR sounds good!

[Buzzec]

With 1.84 we can fix the Miri issues as well, will do that in another PR

Good point – separate PR sounds good!

Stacked it staratlasmeta#2

[febo]

@Buzzec Thanks for this, really nice stuff. I started to look into the Account/AccountInfo changes. One thing that I noticed is that the performance of the entrypoint got a hit from the changes, can't pinpoint exactly where at the moment.

Name	CUs (before)	CUs (after)	Delta
Account (1)	17	21	+4
Account (2)	30	37	+7
Account (3)	37	50	+13
Account (4)	45	63	+18
Account (8)	78	118	+40
Account (16)	143	227	+84
Account (32)	261	430	+169
Account (64)	504	846	+342

I am planning to add your changes incrementally to isolate what change is slowing things down.

[Buzzec]

Any discoveries here?