refactor: extract byte operations into dedicated crate#285
Open
sonicfromnewyoke wants to merge 1 commit intoanza-xyz:mainfrom
Open
refactor: extract byte operations into dedicated crate#285sonicfromnewyoke wants to merge 1 commit intoanza-xyz:mainfrom
sonicfromnewyoke wants to merge 1 commit intoanza-xyz:mainfrom
Conversation
Contributor
|
It's nice to have it right there in the Pinocchio crate |
Contributor
|
Currently, it should not be in the main crate. Rather, it should be in another crate |
Contributor
Author
im thinking maybe it worth to get rid of those helpers at all and use |
Contributor
Yeah make sense. I don't know the opinion of @febo on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
there is a part of functionality that is copy/pasted across Pinocchio crates
Summary of Changes
bytesmodule underpinnochiomain crateinto this module
tokenandtoken-2022crates instead of having duplicated logicalso will be used in one more crate - #284
cc @febo