Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As described in anza-xyz/solana-sdk#569, account resize cannot be safely performed using a delta value. Therefore, entrypoints need to store the original data size to reliably track differences. But doing so consume CUs and not every program needs to resize accounts.
Additionally,
AccountView::resizewas removed since the resize logic is dependent on what the entrypoint does.Solution
This PR enables account resizing in pinocchio by:
"resize"feature to indicate to the entrypoint that the original data size needs to be stored. This consumes2CUs per account.implof the newResizetrait is provided forAccountView, offeringresizeandresize_unchecked.