Merged
Conversation
OliverNChalk
previously approved these changes
Mar 10, 2026
apfitzge
force-pushed
the
reject-zsts-explicitly
branch
from
10fb399 to
e5f08ef
Compare
Contributor
Author
|
@OliverNChalk rebased to deal with conflict on added test (no changes, accepted both) |
src/spsc.rs
Outdated
Comment on lines
+412
to
+414
| if core::mem::size_of::<T>() == 0 { | ||
| return Err(Error::InvalidBufferSize); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if core::mem::size_of::<T>() == 0 { | |
| return Err(Error::InvalidBufferSize); | |
| } | |
| const { | |
| assert!( | |
| core::mem::size_of::<T>() > 0, | |
| "zero-sized types are not supported" | |
| ) | |
| } |
checked locally and this produces a compiler error for the test_zero_sized_types_are_rejected test below
Contributor
Author
There was a problem hiding this comment.
but this just panics instead - which would have alrady happened with a divide by zero. Would rather just return an error.
Contributor
There was a problem hiding this comment.
No this fails to compile instead of failing at runtime. catches the issue much earlier
Contributor
Author
There was a problem hiding this comment.
Oh yeah you're right i missed the wrapping const
Contributor
Author
There was a problem hiding this comment.
done and removed tests.
apfitzge
force-pushed
the
reject-zsts-explicitly
branch
from
e5f08ef to
a87356a
Compare
OliverNChalk
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes