[bls-signatures] Refactor pubkey, signature, and proof of possession modules #463
+1,736
−1,636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As I was tackling #474, I realized that each of the
pubkey.rs,signature.rs, andproof_of_possession.rsfiles are becoming quite long and harder to read.Summary of Changes
In preparation for adding the new
PubkeyAffine,SignatureAffine, andProofOfPossesionAffinetypes, I first did a refactor of thepubkey.rs,signature.rs, andproof_of_possession.rstypes.Each each
pubkey,signature, andproof_of_possessionmodules are divided intopoints.rs: contains theProjectivetype and will soon host theAffinetypebytes.rs: contains the serialized types likePubkey(soon to bePubkeyUncompressed) andPubkeyCompressed.conversion.rs: contains any conversion logic between points