reward-info: Add variant for deactivated stake#634
Merged
joncinque merged 2 commits intoanza-xyz:masterfrom Mar 24, 2026
Merged
reward-info: Add variant for deactivated stake#634joncinque merged 2 commits intoanza-xyz:masterfrom
joncinque merged 2 commits intoanza-xyz:masterfrom
Conversation
#### Problem As mentioned during this [SIMD-0392 amendment](solana-foundation/solana-improvement-documents#488 (comment)), block metadata should carry the information of when a stake account is deactivting. #### Summary of changes Add a new `DeactivatingStake` variant of `RewardType`, to be used in anza-xyz/agave#11332.
t-nelson
reviewed
Mar 23, 2026
reward-info/src/lib.rs
Outdated
| RewardType::Rent => "rent", | ||
| RewardType::Staking => "staking", | ||
| RewardType::Voting => "voting", | ||
| RewardType::DeactivatingStake => "deactivating-stake", |
Contributor
There was a problem hiding this comment.
how do we plan to use this wrt multi-epoch deactivations?
Collaborator
Author
There was a problem hiding this comment.
My thinking is that it has multiple "deactivating" entries, since it's technically still deactivating
Contributor
There was a problem hiding this comment.
i guess my original thought was that they'd get the special designation only in their last deactivation epoch. that is when active delegation goes to zero
...then we can get cute and do the same for first epoch with rewards and never have to scan the account's tx history again 😉
Collaborator
Author
There was a problem hiding this comment.
Fine by me! Either way ✔️ please so I can implement it in Agave
Contributor
There was a problem hiding this comment.
Suggested change
| RewardType::DeactivatingStake => "deactivating-stake", | |
| RewardType::DeactivatedStake => "deactivated-stake", |
change in usage, change in tense 😉
t-nelson
approved these changes
Mar 24, 2026
joncinque
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As mentioned during this SIMD-0392 amendment, block metadata should carry the information of when a stake account is deactivating.
Summary of changes
Add a new
DeactivatingStakevariant ofRewardType, to be used in anza-xyz/agave#11332.