Exposes used_size for mem_outfile #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaarrfk
force-pushed
the
expose_get_used_size_for_mem_outfile
branch
from
8a99388 to
a7eed94
Compare
Contributor
Author
|
is this ok as an implementation? this would be pretty useful for me |
hmaarrfk
force-pushed
the
expose_get_used_size_for_mem_outfile
branch
from
015ca16 to
0e41000
Compare
A tiny improvement to the comments.
Owner
|
Hi Mark, Thank you for having a look at my code, and producing this useful commit. I will add it soon, as this requires a version bump. Kind regards, |
Contributor
Author
|
Awesome thanks. Yeah i was using mem_outfile and figured i would have a look at the open issue around it! |
Owner
|
Thank you Mark. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165