Skip to content

Conversation

@HeaoYe
Copy link
Contributor

@HeaoYe HeaoYe commented Aug 25, 2025

Fix #196

Use cmake higher-level abstractions to handle platform differences of -fPIC

# if (NOT MSVC)
#   target_compile_options(openjph PRIVATE -fPIC)
# endif()
set_target_properties(openjph PROPERTIES POSITION_INDEPENDENT_CODE ON)

Thanks for considering this contribution!I'm looking forward to your feedback and am open to making any necessary changes.

@aous72
Copy link
Owner

aous72 commented Aug 25, 2025

Hi HeaoYe,

Thank you for submitting this PR.
Your proposed change is the correct way to have PIC code; I did not know about it.

I will include this PR in the next release.

Kind regards,
Aous.

@HeaoYe
Copy link
Contributor Author

HeaoYe commented Aug 25, 2025

Thanks for the feedback!

@aous72 aous72 merged commit 6a66602 into aous72:master Aug 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-fPIC was passes to Windows/Clang and caused some errors.

2 participants