Better (???) way of reusing ci workflow#57305
Closed
potiuk wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
force-pushed
the
better-ci-reusable-workflows
branch
4 times, most recently
from
d682239 to
b19e7bd
Compare
Instead of dynamically checking and updating the ARM/AMD runner type, we can use reusable workflows and statically define two types of workflows: ARM and AMD. There are some benefits of that approach: * we can run only AMD workflows for "PRs" - they will be in the same AMD workflow * AMD / ARM workflows are run at fixed hours * There is no dynamic checking for workflows when running selective checks * Most importantly - both AMD and ARM workflows run in `vX-Y-test` branches after merge (previously they were alternating - similarly to canary builds)
potiuk
force-pushed
the
better-ci-reusable-workflows
branch
from
b19e7bd to
aeb7867
Compare
potiuk
changed the title
Member
Author
|
Comment - UX of GitHub is quite terrible for 3 levels of nesting... This is almost for sure not "better" now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of dynamically checking and updating the ARM/AMD runner type, we can use reusable workflows and statically define two types of workflows: ARM and AMD.
There are some benefits of that approach:
vX-Y-testbranches after merge (previously they were alternating - similarly to canary builds)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.