Fix : 'airflow connections test' failure by adding DB fallback #59038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where the
airflow connections testCLI command would fail with "Connection not found" or "conn_id isn't defined", even when the connection was clearly visible usingairflow connections list.The Issue:
Previously,
connections_testrelied solely onConnection.get_connection_from_secrets(args.conn_id). If the secrets backend failed to retrieve the connection (e.g., due to environment issues or Hook initialization failures), the CLI would exit with an error, ignoring the fact that the connection might exist in the Metastore Database.In contrast,
connections_listqueries the database directly, creating a discrepancy between the two commands.The Fix:
I have updated
airflow/cli/commands/connection_command.pyto implement a fallback mechanism:AirflowNotFoundExceptionor returnsNone), it now explicitly checks the Database usingcreate_session.Related Issue
Closes #58567
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.