[v2-11-test] Fix root logger level cache invalidation in LoggerMutationHelper#61644
Open
seoin0110 wants to merge 1 commit intoapache:v2-11-testfrom
Open
[v2-11-test] Fix root logger level cache invalidation in LoggerMutationHelper#61644seoin0110 wants to merge 1 commit intoapache:v2-11-testfrom
seoin0110 wants to merge 1 commit intoapache:v2-11-testfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Contributor
|
FYI tests fail on the same problem that I attempt to fix in #61651 ... probably unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Currently, the code assigns the log level directly to the
.levelattribute.This violates the official Python documentation, which explicitly states:
setLevel(), which has checks for the level passed to it.This direct assignment bypasses the Python logging module's
_invalidate_cache()mechanism. If the root logger was previously initialized with a different level (e.g., WARNING), the stale cache persists. This causes logs (e.g., INFO) to be suppressed during task execution even after the level update.What
Change the assignment to use the standard method
.setLevel().This ensures the internal cache is cleared via
_invalidate_cache()and the new level takes effect immediately.