Fix: Restore task_instance_history sequence on downgrade#61976
Open
vatsrahul1001 wants to merge 1 commit intoapache:mainfrom
Open
Fix: Restore task_instance_history sequence on downgrade#61976vatsrahul1001 wants to merge 1 commit intoapache:mainfrom
vatsrahul1001 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a rollback from Airflow 3 to Airflow 2, the
task_instance_history_id_seqPostgreSQL sequence was not being recreated. This causedtask_instance_historyinserts to fail with NULL constraint violations since theidcolumn had no DEFAULT value for auto-increment.Root Cause
In the upgrade path (migration 0060), the
idcolumn is dropped:batch_op.drop_column("id")When PostgreSQL drops a column with an associated sequence, the sequence is also dropped (due to ownership).
Testing
breeze start-airflow --executor CeleryExecutor --backend postgresairflow db downgrade --to-revision e00344393f31 -y{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.