Open
Conversation
sarth-akvaish
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
| <CalendarCell | ||
| backgroundColor={scale.getColor(emptyCounts)} | ||
| cellData={emptyData} | ||
| data-testid="calendar-cell" |
Contributor
There was a problem hiding this comment.
These are redundant because CalendarCell.tsx already adds data-testid="calendar-cell"
Contributor
Author
There was a problem hiding this comment.
yes, removing this
| <CalendarCell | ||
| backgroundColor={scale.getColor(hourData.counts)} | ||
| cellData={formattedHourData} | ||
| data-testid="calendar-cell" |
Contributor
There was a problem hiding this comment.
These are redundant because CalendarCell.tsx already adds data-testid="calendar-cell"
sarth-akvaish
force-pushed
the
test/Dag-Calendar-Page
branch
from
896f98c to
2837fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E tests for Dag Calendar Tab
This PR adds E2E tests for Dag calendar tab
Closes : #59544
Added testids in the Calendar Components for better selector tracking.
The test covers :
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.